cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8458) Device-orientation tests fails on windows even compass device in not available
Date Wed, 11 Feb 2015 14:50:13 GMT

    [ https://issues.apache.org/jira/browse/CB-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316292#comment-14316292
] 

ASF subversion and git services commented on CB-8458:
-----------------------------------------------------

Commit 7f813a89a1438bbdc35d5df63fbbd380a7bc1ee5 in cordova-plugin-device-orientation's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-orientation.git;h=7f813a8
]

CB-8458 Fixes false failure of test, when compass hardware is not available

* Factor out compass detection to beforeEach
* Remove false-failure spec


> Device-orientation tests fails on windows even compass device in not available
> ------------------------------------------------------------------------------
>
>                 Key: CB-8458
>                 URL: https://issues.apache.org/jira/browse/CB-8458
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Device Orientation
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>
> Device orientation tests detects if compass hardware is available on device inside of
dedicated {{it()}} block and if compass is not available this tests is marked as failed.
> Proposed approach - move corresponding logic to {{beforeEach}} block and remove false
failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message