cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8425) Media plugin .ctr: make src param required as per spec
Date Thu, 05 Feb 2015 14:53:35 GMT

    [ https://issues.apache.org/jira/browse/CB-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307327#comment-14307327
] 

ASF subversion and git services commented on CB-8425:
-----------------------------------------------------

Commit 52bccd048806e0943d644d3a5bb347520666b51f in cordova-plugin-media's branch refs/heads/master
from sgrebnov
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=52bccd0 ]

CB-8425 Media plugin .ctr: make src param required as per spec


> Media plugin .ctr: make src param required as per spec
> ------------------------------------------------------
>
>                 Key: CB-8425
>                 URL: https://issues.apache.org/jira/browse/CB-8425
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Media
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: cordova-plugin-media
>
> As per documentation src is a mandatory but in argscheck it is optional. Due to this
in some unit tests 'undefined' is passed to native proxy and may cause some issues (for example
I see related internal errors on Windows)
> var Media = function(src, successCallback, errorCallback, statusCallback) {
>     argscheck.checkArgs('SFFF', 'Media', arguments);
>     this.id = utils.createUUID();
>     mediaObjects[this.id] = this;
>     this.src = src;
> ...
>     exec(null, this.errorCallback, "Media", "create", [this.id, this.src]);
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message