cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8395) Some contacts tests are green instead of pending on wp8
Date Mon, 02 Feb 2015 10:49:34 GMT

    [ https://issues.apache.org/jira/browse/CB-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301141#comment-14301141
] 

ASF GitHub Bot commented on CB-8395:
------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/55

    CB-8395 marked unsupported tests pending on wp8

    This fixes https://issues.apache.org/jira/browse/CB-8395

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts test-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit 570dcc2ed9073eb4f3fa803041cd0d9b04303b87
Author: alsorokin <alexander.sorokin@akvelon.com>
Date:   2015-02-02T10:47:48Z

    CB-8395 marked unsupported tests pending on wp8

----


> Some contacts tests are green instead of pending on wp8
> -------------------------------------------------------
>
>                 Key: CB-8395
>                 URL: https://issues.apache.org/jira/browse/CB-8395
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts, WP8
>            Reporter: Alexander Sorokin
>            Assignee: Jesse MacFadyen
>
> contacts.spec.6, contacts.spec.20, contacts.spec.21 and contacts.spec.24 are green on
wp8 because of the following code:
> {code}
> if (isWindowsPhone8) {
>   done();
>   return;
> }
> {code}
> Instead of marking them green right away we need to mark them pending.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message