cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8390) <framework custom="false"/> broken for gradle projects
Date Tue, 03 Feb 2015 02:08:34 GMT

    [ https://issues.apache.org/jira/browse/CB-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302658#comment-14302658
] 

ASF GitHub Bot commented on CB-8390:
------------------------------------

GitHub user agrieve opened a pull request:

    https://github.com/apache/cordova-lib/pull/158

    CB-8390 android: Make <framework custom=false> to work with Gradle

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agrieve/cordova-lib CB-8390

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #158
    
----
commit db9f836019038c311c09548ddd2d431bb9cd5950
Author: Andrew Grieve <agrieve@chromium.org>
Date:   2015-02-03T02:06:30Z

    CB-8390 android: Make <framework custom=false> to work with Gradle

----


> <framework custom="false"/> broken for gradle projects
> ------------------------------------------------------
>
>                 Key: CB-8390
>                 URL: https://issues.apache.org/jira/browse/CB-8390
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, CordovaLib
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> {code}
> <framework custom=false>
> {code}
> allows referencing of android support libraries and play services, which live within
the user's SDK directory.
> https://developer.android.com/tools/support-library/features.html
> There is currently ANT-specific logic within plugman to handle them, and they don't work
at all for gradle projects.
> https://github.com/apache/cordova-lib/blob/e05c656ef3d77d6c5e9232ed4e6ddbd3e29654eb/cordova-lib/src/plugman/platforms/android.js#L118
> (note the use of local.properties)
> Some example tags:
> {code}
> <framework src="extras/android/support/v4" />
> <framework src="extras/android/support/v13" />
> <framework src="google/google_play_services/libproject/google-play-services_lib" />
> {code}
> Currently (for ANT), these libraries were added as sub-projects using the path to them
within the SDK directory. For gradle, we should be added them via:
> {code}
> dependencies {
>   compile 'com.android.support:support-v4:21.0.+'
>   compile 'com.android.support:support-v13:18.0.+'
>   compile 'com.google.android.gms:play-services:6.5.87'
> }
> {code}
> Proposed change:
> Look for `src` in the form of `extras/android/support/v4` and map that to `com.android.support:support-v4`.
Just use a hardcoded lookup table, as this is just for backwards compat.
> Add support for `src` in the form of `com.android.support:support-v4`, and add these
to the project.properties file, in the same way that we do for subprojects and gradleReference
frameworks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message