cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-8390) <framework custom="false"/> broken for gradle projects
Date Tue, 03 Feb 2015 02:08:34 GMT


ASF GitHub Bot commented on CB-8390:

GitHub user agrieve opened a pull request:

    CB-8390 android: Make <framework custom=false> to work with Gradle


You can merge this pull request into a Git repository by running:

    $ git pull CB-8390

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #158
commit db9f836019038c311c09548ddd2d431bb9cd5950
Author: Andrew Grieve <>
Date:   2015-02-03T02:06:30Z

    CB-8390 android: Make <framework custom=false> to work with Gradle


> <framework custom="false"/> broken for gradle projects
> ------------------------------------------------------
>                 Key: CB-8390
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, CordovaLib
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
> {code}
> <framework custom=false>
> {code}
> allows referencing of android support libraries and play services, which live within
the user's SDK directory.
> There is currently ANT-specific logic within plugman to handle them, and they don't work
at all for gradle projects.
> (note the use of
> Some example tags:
> {code}
> <framework src="extras/android/support/v4" />
> <framework src="extras/android/support/v13" />
> <framework src="google/google_play_services/libproject/google-play-services_lib" />
> {code}
> Currently (for ANT), these libraries were added as sub-projects using the path to them
within the SDK directory. For gradle, we should be added them via:
> {code}
> dependencies {
>   compile ''
>   compile ''
>   compile ''
> }
> {code}
> Proposed change:
> Look for `src` in the form of `extras/android/support/v4` and map that to ``.
Just use a hardcoded lookup table, as this is just for backwards compat.
> Add support for `src` in the form of ``, and add these
to the file, in the same way that we do for subprojects and gradleReference

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message