cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
Date Mon, 23 Feb 2015 18:25:44 GMT

    [ https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333619#comment-14333619
] 

ASF GitHub Bot commented on CB-7827:
------------------------------------

Github user cjpearson commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/171#discussion_r25187454
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg, template_dir,
opts) {
         if (/android|ios/.exec(platDetails.platform) && semver.gt(platDetails.version,
'3.3.0')) {
             args.push('--cli');
         }
    -
    +    
         var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
         // CB-6992 it is necessary to normalize characters
         // because node and shell scripts handles unicode symbols differently
         // We need to normalize the name to NFD form since iOS uses NFD unicode form
         var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) : cfg.name();
         args.push(output, pkg, name);
    +
    +    var activityName = cfg.android_activityName();
    +    if (activityName && platDetails.platform === 'android') {
    +        activityName = activityName.replace(/W/g, '');
    +	args.push(activityName);
    --- End diff --
    
    Thanks for the review. I'll add this.


> manifest/application/activity[android:name] always CordovaApp
> -------------------------------------------------------------
>
>                 Key: CB-7827
>                 URL: https://issues.apache.org/jira/browse/CB-7827
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 4.0.0
>         Environment: Windows 8.1 x64, NodeJs 0.10.32
>            Reporter: Sergey
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message