cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Bektchiev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7518) Android - Don't run "android" command from within CLI/Plugman
Date Tue, 03 Feb 2015 15:56:34 GMT

    [ https://issues.apache.org/jira/browse/CB-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303477#comment-14303477
] 

Martin Bektchiev commented on CB-7518:
--------------------------------------

Thank you for the prompt response. The only issue that I see with this approach is that if
the library contains its own build.xml which defines custom logic (e.g. post-build and/or
pre-build scripts) it will be overwritten with the default template. Probably we should at
least check for its existence and leave it if it's already there.


> Android - Don't run "android" command from within CLI/Plugman
> -------------------------------------------------------------
>
>                 Key: CB-7518
>                 URL: https://issues.apache.org/jira/browse/CB-7518
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugman
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> The Android SDK auto-detection code (e.g. location ANDROID_HOME, putting things in your
PATH), is a part of cordova-android's check_reqs script, which is not called from within CLI.
So, we don't want to rely on the presense of the "android" executable from within CLI. 
> Currently the only time it's called is for `<framework>` within plugins. With the
ANDROID_HOME changes in 3.6.0, running this isn't necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message