cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3360) Set custom InAppBrowser user-agent
Date Sun, 22 Feb 2015 21:18:12 GMT

    [ https://issues.apache.org/jira/browse/CB-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332381#comment-14332381
] 

ASF GitHub Bot commented on CB-3360:
------------------------------------

GitHub user sinofool opened a pull request:

    https://github.com/apache/cordova-ios/pull/131

    CB-3360 Set custom User-Agent

    Add two configurations to set user agent of webview.
    OverrideUserAgent to override UA to the setting value.
    AppendUserAgent to append the setting value to default UA.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sinofool/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit b2e55dfe909cadd093c200f7eb2b4831f3846845
Author: Bochun Bai <bbc@sinofool.net>
Date:   2015-02-21T08:44:00Z

    CB-3360 Set custom User-Agent

----


> Set custom InAppBrowser user-agent
> ----------------------------------
>
>                 Key: CB-3360
>                 URL: https://issues.apache.org/jira/browse/CB-3360
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, BlackBerry, Plugin InAppBrowser, WP8
>    Affects Versions: 2.7.0
>         Environment: iOS, Android, WP8, BlackBerry
>            Reporter: Kevin Simpson
>            Assignee: Joe Bowser
>            Priority: Minor
>              Labels: Cordova, InAppBrowser, android
>
> Currently you can set a custom user-agent for the main Cordova webview by overriding
the init method for the DroidGap class. However, when opening a page in the InAppBrowser,
that webview will still contain the default user-agent.
> There are two solutions that I have thought of to this:
> 1. Set the user-agent of the InAppBrowser webview to whatever the user-agent in the Cordova
webview is set to. (This is what I am currently doing, as it was a one line change, but it
requires rebuilding Cordova manually)
> 2. Have some sort of configuration option to set the user-agent for the InAppBrowser.
This would allow a different user-agent from the main webview, but is also a more involved
change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message