Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C9E5510BAD for ; Thu, 8 Jan 2015 04:21:33 +0000 (UTC) Received: (qmail 81923 invoked by uid 500); 8 Jan 2015 04:21:34 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 81896 invoked by uid 500); 8 Jan 2015 04:21:34 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 81882 invoked by uid 99); 8 Jan 2015 04:21:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jan 2015 04:21:34 +0000 Date: Thu, 8 Jan 2015 04:21:34 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8270) Objective-C methods on categories should be named with a prefix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268806#comment-14268806 ] ASF GitHub Bot commented on CB-8270: ------------------------------------ GitHub user lingoer opened a pull request: https://github.com/apache/cordova-ios/pull/124 [CB-8270] rename category methods for JSON handling with a prefix. According to [Apple's documentation](https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW4) , naming a Category method without a prefix would possibly cause a Name Clash In CordovaLib/Classes/CDVJSON.h : NSArray(CDVJSONSerializing) The method name should starts with a prefix Actually, it clashes with the TencentOpenAPI framework which is a major sns platform in China. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lingoer/cordova-ios CB-8270 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #124 ---- commit 75e72a53f062115066e2fc9305c8dfb0ad5cfeb8 Author: Ruoyu Fu Date: 2015-01-08T04:08:37Z [CB-8270] rename category methods for JSON handling with a prefix. ---- > Objective-C methods on categories should be named with a prefix > --------------------------------------------------------------- > > Key: CB-8270 > URL: https://issues.apache.org/jira/browse/CB-8270 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS > Affects Versions: Master > Environment: All iOS platforms > Reporter: Ruoyu Fu > Priority: Critical > Labels: categories, ios, namespace > Fix For: Master > > Original Estimate: 168h > Remaining Estimate: 168h > > According to Apple's documentation, naming a Category method without a prefix would possibly cause a Name Clash > https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW4 > In CordovaLib/Classes/CDVJSON.h : NSArray(CDVJSONSerializing) > The method name should starts with a prefix -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org