Return-Path: 
 <issues-return-37377-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E5CC4174EF
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Fri, 23 Jan 2015 23:24:35 +0000 (UTC)
Received: (qmail 22357 invoked by uid 500); 23 Jan 2015 23:24:35 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 22297 invoked by uid 500); 23 Jan 2015 23:24:35 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 22016 invoked by uid 99); 23 Jan 2015 23:24:35 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2015 23:24:35 +0000
Date: Fri, 23 Jan 2015 23:24:35 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12764742.1420338390000.162396.1422055475377@Atlassian.JIRA>
In-Reply-To: <JIRA.12764742.1420338390000@Atlassian.JIRA>
References: <JIRA.12764742.1420338390000@Atlassian.JIRA>
 <JIRA.12764742.1420338390228@arcas>
Subject: [jira] [Commented] (CB-8239) Add support for git urls to 'cordova
 platform add'
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290202#comment-14290202 ] 

ASF GitHub Bot commented on CB-8239:
------------------------------------

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r23488149
  
    --- Diff: cordova-lib/src/cordova/util.js ---
    @@ -55,6 +61,8 @@ exports.preProcessOptions = preProcessOptions;
     exports.addModuleProperty = addModuleProperty;
     exports.getOrigWorkingDirectory = getOrigWorkingDirectory;
     exports.fixRelativePath = fixRelativePath;
    +exports.getPlatformDetailsFromDir = getPlatformDetailsFromDir;
    --- End diff --
    
    moved cloning code to new module: https://github.com/MSOpenTech/cordova-lib/commit/9d267df1b389ef1f70dcbca4292e1ffd6641e895


> Add support for git urls to 'cordova platform add'
> --------------------------------------------------
>
>                 Key: CB-8239
>                 URL: https://issues.apache.org/jira/browse/CB-8239
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CLI, CordovaLib
>            Reporter: Omar Mefire
>
> Allow the following scenarios:
> - users can issue 'cordova platform add https://github.com/apache/cordova-android.git' and the git repo will be cloned and used.
> - users can issue 'cordova platform add android@https://github.com/apache/cordova-android.git' and the git repo will be cloned and used.
> - users can issue 'cordova platform add android' and if their config.xml file contains: '<engine id='android' version='https://github.com/apache/cordova-android.git' />, then the git repo pointed to by config.xml will be cloned and used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org