cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8382) Make CordovaActivity not implement CordovaInterface
Date Fri, 30 Jan 2015 02:09:34 GMT

    [ https://issues.apache.org/jira/browse/CB-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298099#comment-14298099
] 

Andrew Grieve commented on CB-8382:
-----------------------------------

Created a PR for review of this: 
https://github.com/apache/cordova-android/pull/152

> Make CordovaActivity not implement CordovaInterface
> ---------------------------------------------------
>
>                 Key: CB-8382
>                 URL: https://issues.apache.org/jira/browse/CB-8382
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> CordovaWebView.java used to enforce that they CordovaActivity could be cast to a CordovaInterface,
but this has been fixed with the move to a two-step initialization (separate call to init()).

> With this being fixed, it would clean up the code a bit by shrinking the API surface
of CordovaActivity. Further, it would ensure that the activity==interface assumption does
not return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message