cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8377) <runs> tag in Plugin.xml aren't parsed properly
Date Thu, 29 Jan 2015 16:35:36 GMT

    [ https://issues.apache.org/jira/browse/CB-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297108#comment-14297108
] 

ASF GitHub Bot commented on CB-8377:
------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-lib/pull/156

    CB-8377 Fixed <runs> tag parsing

    This fixes https://issues.apache.org/jira/browse/CB-8377

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-8377

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 3690ed5f7776a80a24a385dd795d71c19599010a
Author: alsorokin <alexander.sorokin@akvelon.com>
Date:   2015-01-29T12:16:40Z

    CB-8377 Fixed <runs> tag parsing

----


> <runs> tag in Plugin.xml aren't parsed properly
> -----------------------------------------------
>
>                 Key: CB-8377
>                 URL: https://issues.apache.org/jira/browse/CB-8377
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Alexander Sorokin
>            Priority: Critical
>
> With the example of mobile-spec on windows:
> 1. cordova-mobile-spec/createmobilespec/createmobilespec.cmd --windows mobilespec
> 2. go to \mobilespec\platforms\windows\www and open cordova_plugins.js
> Expected result
> there must be a section with "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
>     {
>         "file": "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
>         "id": "org.apache.cordova.globalization.GlobalizationProxy",
>         "runs": true
>     },
> {code}
> Actual result
> There is a section without "runs" element
> {code:title=cordova_plugins.js|borderStyle=solid}
>     {
>         "file": "plugins/org.apache.cordova.globalization/src/windows/GlobalizationProxy.js",
>         "id": "org.apache.cordova.globalization.GlobalizationProxy"
>     },
> {code}
> This indicates that globalization plugin's Plugin.xml was not parsed properly:
> {code:title=Plugin.xml|borderStyle=solid}
>     <!-- windows -->
>     <platform name="windows">
>         <js-module src="src/windows/GlobalizationProxy.js" name="GlobalizationProxy">
>             <runs />
>         </js-module>
>         <framework src="src/Windows/GlobalizationProxy.winmd" custom="true"/>
>     </platform>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message