cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8337) Keyboard plugin resizes incorrectly with external keyboard attached
Date Wed, 21 Jan 2015 19:07:35 GMT

    [ https://issues.apache.org/jira/browse/CB-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286076#comment-14286076
] 

ASF GitHub Bot commented on CB-8337:
------------------------------------

GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-plugins/pull/18

    CB-8337: Fix keyboardShrinksView for external keyboards, CB-8339 enable keyboardShrinksView
on iOS 7.1+

    Instead of listening for keyboard show and hide events, the plugin now listens for keyboard
frame change events and responds accordingly. This should also fix CB-5711 or any other case
where the keyboard frame changes without firing a show or hide event.
    
    This also changes keyboardShrinksView from being a no-op on iOS >= 7.0 to being a no-op
on iOS = 7.0 and  fixes the screen being pushed up before being resized (CB-5642.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-plugins master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugins/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
    
----
commit d1e9b85ad06af10759e68dcbc2b6af8cb1229e67
Author: Connor Pearson <cjp822@gmail.com>
Date:   2015-01-09T17:24:53Z

    Change KeyboardShrinkView to use KeyboardFrameWillChange notification instead. Have animation
match the keyboard animation. Support external keyboards.

commit 398cca80652f6a6d0bd00440708db66b52380b81
Author: Connor Pearson <cjp822@gmail.com>
Date:   2015-01-12T16:25:28Z

    Instead of adding and removing observer when _shrinkView changes, check for _shrinkView
in the method that is called. Always resize the webview if the keyboard is moving off screen.
This covers the case when shrinkView is disabled while the keyboard is visible. Only disable
the webview push up if shrinkView is enabled. Fix regression which broke disableScrollingInShrinkView.

commit 9414dbc01d109a54855f94a8d8223209ce82324f
Author: Connor Pearson <cjp822@gmail.com>
Date:   2015-01-12T17:15:58Z

    Take into account whether or not the accessory bar is showing when shrinking the webview.

commit 2b83934c38f233253064a5c598b34dfdea7fc352
Author: Connor Pearson <cjp822@gmail.com>
Date:   2015-01-12T18:27:58Z

    Handle split and undocked keyboards. They should hover over the app and not resize the
webview.

commit 5fb233b19ae8638c933506447bf54ffb89659c80
Author: Connor Pearson <cjp822@gmail.com>
Date:   2015-01-12T18:38:01Z

    Remove empty getter/setter. Use autogenerated instead.

----


> Keyboard plugin resizes incorrectly with external keyboard attached
> -------------------------------------------------------------------
>
>                 Key: CB-8337
>                 URL: https://issues.apache.org/jira/browse/CB-8337
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Keyboard
>         Environment: iOS
>            Reporter: Connor Pearson
>
> When using an external keyboard, the keyboard plugin should only shrink the webview enough
to accommodate the accessory bar. It instead shrinks an area the size of the full keyboard,
leaving an empty space.
> See http://i.imgur.com/pKh53JR.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message