cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8255) Android gradle builds should be configurable via gradle properties instead of custom environment variables
Date Tue, 06 Jan 2015 20:59:34 GMT

    [ https://issues.apache.org/jira/browse/CB-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266756#comment-14266756
] 

ASF GitHub Bot commented on CB-8255:
------------------------------------

GitHub user agrieve opened a pull request:

    https://github.com/apache/cordova-android/pull/145

    CB-8255 Use properties rather than environment variables for gradle settings

    For review. I'll merge in if it's good to go!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agrieve/cordova-android gradle-props

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #145
    
----
commit 2ddebd36dd866eb3e3e298a03cc943d7f334a5c4
Author: Andrew Grieve <agrieve@chromium.org>
Date:   2015-01-06T20:56:09Z

    CB-8255 Use properties rather than environment variables for gradle settings

----


> Android gradle builds should be configurable via gradle properties instead of custom
environment variables
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CB-8255
>                 URL: https://issues.apache.org/jira/browse/CB-8255
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> Gradle has excellent support for build properties, as explained here:
> http://www.gradle.org/docs/current/userguide/tutorial_this_and_that.html
> Our use of environment variables isn't great, mostly because in Java, environment variables
are immutable, and so can't be changed via build-extras.gradle. There needs to be a way to
make IDE builds use the same settings as command-line builds, and switching to use gradle
properties is a good step towards this (which can be set via environment variables anyways!)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message