cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8239) Add support for git urls to 'cordova platform add'
Date Tue, 13 Jan 2015 22:20:35 GMT

    [ https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276071#comment-14276071
] 

ASF GitHub Bot commented on CB-8239:
------------------------------------

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r22900366
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -76,97 +77,94 @@ function add(hooksRunner, projectRoot, targets, opts) {
         }
     
         return hooksRunner.fire('before_platform_add', opts)
    -    .then(function() {
    -        return promiseutil.Q_chainmap(targets, function(target) {
    -            // For each platform, download it and call its "create" script.
    -            var parts = target.split('@');
    -            var platform = parts[0];
    -            var version = parts[1];
    -
    -            return Q.when().then(function() {
    -                if (!(platform in platforms)) {
    -                    return getPlatformDetailsFromDir(target);
    -                } else {
    -                    if (!version) {
    -                        events.emit('verbose', 'No version supplied. Retrieving version
from config.xml...');
    -                    }
    -                    version = version || getVersionFromConfigFile(platform, cfg);
    -                    var tgt = version ? (platform + '@' + version) : platform;
    -                    return isDirectory(version) ? getPlatformDetailsFromDir(version)
: downloadPlatform(projectRoot, tgt, opts);
    -                }
    -            }).then(function(platDetails) {
    -                var template = config_json && config_json.lib && config_json.lib[platform]
&& config_json.lib[platform].template || null;
    -                return call_into_create(platDetails.platform, projectRoot, cfg, platDetails.libDir,
template, opts);
    -            });
    -        });
    -    })
    -    .then(function() {
    -        return hooksRunner.fire('after_platform_add', opts);
    -    });
    +	.then(function () {
    --- End diff --
    
    please don't insert tabs. and please try to avoid rewriting large chunks of files when
adding features.


> Add support for git urls to 'cordova platform add'
> --------------------------------------------------
>
>                 Key: CB-8239
>                 URL: https://issues.apache.org/jira/browse/CB-8239
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CLI, CordovaLib
>            Reporter: Omar Mefire
>
> Allow the following scenarios:
> - users can issue 'cordova platform add https://github.com/apache/cordova-android.git'
and the git repo will be cloned and used.
> - users can issue 'cordova platform add android@https://github.com/apache/cordova-android.git'
and the git repo will be cloned and used.
> - users can issue 'cordova platform add android' and if their config.xml file contains:
'<engine id='android' version='https://github.com/apache/cordova-android.git' />, then
the git repo pointed to by config.xml will be cloned and used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message