cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8239) Add support for git urls to 'cordova platform add'
Date Thu, 22 Jan 2015 20:47:35 GMT

    [ https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288186#comment-14288186
] 

ASF GitHub Bot commented on CB-8239:
------------------------------------

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r23408346
  
    --- Diff: cordova-lib/spec-cordova/lazy_load.spec.js ---
    @@ -26,7 +26,8 @@ var lazy_load = require('../src/cordova/lazy_load'),
         request = require('request'),
         fs = require('fs'),
         Q = require('q'),
    -    platforms = require('../src/cordova/platforms');
    +    platforms = require('../src/cordova/platforms'),
    --- End diff --
    
    The first several screens of this diff are no-op changes. Please have a look through the
diff yourself and undo any highlighted lines that maybe your editor is changing on you? Might
be easier to start fresh and re-apply your change rather than try and fix up this one.


> Add support for git urls to 'cordova platform add'
> --------------------------------------------------
>
>                 Key: CB-8239
>                 URL: https://issues.apache.org/jira/browse/CB-8239
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CLI, CordovaLib
>            Reporter: Omar Mefire
>
> Allow the following scenarios:
> - users can issue 'cordova platform add https://github.com/apache/cordova-android.git'
and the git repo will be cloned and used.
> - users can issue 'cordova platform add android@https://github.com/apache/cordova-android.git'
and the git repo will be cloned and used.
> - users can issue 'cordova platform add android' and if their config.xml file contains:
'<engine id='android' version='https://github.com/apache/cordova-android.git' />, then
the git repo pointed to by config.xml will be cloned and used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message