cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8226) 'cordova platform add' should look into config.xml for correct engine element when no version is provided
Date Wed, 07 Jan 2015 17:24:36 GMT

    [ https://issues.apache.org/jira/browse/CB-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267908#comment-14267908
] 

ASF GitHub Bot commented on CB-8226:
------------------------------------

Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/140#issuecomment-69056950
  
    travis-ci failure not related to my changes.


> 'cordova platform add' should look into config.xml for correct engine element when no
version is provided
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: CB-8226
>                 URL: https://issues.apache.org/jira/browse/CB-8226
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Omar Mefire
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> When the 'cordova platform add' command is executed with no version specified (e.g: user
runs ‘cordova platform add android’ instead of ‘cordova platform add android@3.6.4’),
cordova-lib should look at the config.xml file for the correct <engine> element and
use its version. It should default to using the pinned version if there is no corresponding
<engine> element in the config.xml file. 
> For example, if the user enters : 'cordova platform add android' and the config.xml file
contains this entry: <cdv:engine id="android" version="file://C:/folder/to/android/platform"
/>, We should use the specified folder's bin/create scripts to add the android platform,
not the default version.
> The engine element in config.xml could be one of the following form :
> 1- <cdv:engine id="android" version="3.6.0" />
> 2- <cdv:engine id="android" version="file://C:/folder/to/android/platform" />



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message