cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-8043) Orientation preference's value set to anything but "landscape" or "portrait" doesn't work.
Date Fri, 02 Jan 2015 13:21:15 GMT


ASF GitHub Bot commented on CB-8043:

Github user MMrko commented on the pull request:
    Thanks for the feedback! 
    1. True, pardon my ignorance :) I removed the style-only changes
    2. I moved the new functionality in to a separate [helper module](/MMrko/cordova-lib/tree/fix-orientation-pref/cordova-lib/src/cordova/metadata/helpers/).
The platform parsers now use this helper module by inheriting a [base parser](/MMrko/cordova-lib/tree/fix-orientation-pref/cordova-lib/src/cordova/metadata/parser.js),
which the helper module extends
    The platform parsers required the most refactoring. Previously the methods in each platform
parser were assigned in a way that overrode the prototype. This needed to be refactored to
allow the platform parsers to inherit from a base parser without overriding it (see 918b47eba0308869b38a91a83055c26c15791bb6).

> Orientation preference's value set to anything but "landscape" or "portrait" doesn't
> ------------------------------------------------------------------------------------------
>                 Key: CB-8043
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: RĂ©mi Couturier
> cordova-cli: 4.1.2
> cordova-android: 3.6.4
> mac: osx yosemite
> In config.xml, setting the orientation preference's value to anything but "landscape"
or "portrait" doesn't work. Complete list of possible value:
> For example when setting the value to "userLandscape" and building the app (cordova build
android), I'm getting this message: "Unknown value for orientation preference: userLandscape".

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message