cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8213) coho verify-tags dies ungracefully - fatal isn't defined on bad input
Date Wed, 24 Dec 2014 18:46:15 GMT

    [ https://issues.apache.org/jira/browse/CB-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258439#comment-14258439
] 

ASF subversion and git services commented on CB-8213:
-----------------------------------------------------

Commit a1db346163ef38562cf23ef501a12367c95459b1 in cordova-coho's branch refs/heads/master
from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=a1db346 ]

CB-8213 Fix ReferenceError when verify-tags is given malformed input


> coho verify-tags dies ungracefully - fatal isn't defined on bad input
> ---------------------------------------------------------------------
>
>                 Key: CB-8213
>                 URL: https://issues.apache.org/jira/browse/CB-8213
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Coho
>            Reporter: Josh Soref
>            Assignee: Andrew Grieve
>
> {quote}
> echo 'codova-android: 2.0.0 (fffffff)' | ./coho verify-tags 
> {quote}
> {quote}
> Running from ~/Cordova
> ~/Cordova/cordova-coho/node_modules/co/index.js:290
>     throw err;
>           ^
> ReferenceError: fatal is not defined
>     at callee$0$0$ (~/Cordova/cordova-coho/src/verify-tags.js:78:17)
>     at Empty.invoke (~/Cordova/cordova-coho/node_modules/gnode/node_modules/regenerator/runtime.js:178:31)
>     at next (~/Cordova/cordova-coho/node_modules/co/index.js:83:21)
>     at ~/Cordova/cordova-coho/node_modules/co/index.js:102:18
>     at ~/Cordova/cordova-coho/node_modules/co/index.js:222:7
>     at _fulfilled (~/Cordova/cordova-coho/node_modules/q/q.js:798:54)
>     at self.promiseDispatch.done (~/Cordova/cordova-coho/node_modules/q/q.js:827:30)
>     at Promise.promise.promiseDispatch (~/Cordova/cordova-coho/node_modules/q/q.js:760:13)
>     at ~/Cordova/cordova-coho/node_modules/q/q.js:574:44
>     at flush (~/Cordova/cordova-coho/node_modules/q/q.js:108:17)
> {quote}
> Yes: {{cordova}} is written as {{codova}}, but the code shouldn't crash -- it does because
{{fatal}} isn't defined.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message