cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8210) Prep cordova-android for CSP by removing eval()s
Date Wed, 24 Dec 2014 18:38:13 GMT

    [ https://issues.apache.org/jira/browse/CB-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258430#comment-14258430
] 

ASF GitHub Bot commented on CB-8210:
------------------------------------

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/142#discussion_r22261664
  
    --- Diff: framework/src/org/apache/cordova/LinearLayoutSoftKeyboardDetect.java ---
    @@ -87,14 +85,12 @@ else if (screenHeight == width)
             // If the height as gotten bigger then we will assume the soft keyboard has
             // gone away.
             else if (height > oldHeight) {
    -            if (app != null)
    -                app.appView.sendJavascript("cordova.fireDocumentEvent('hidekeyboard');");
    +            App.fireJavascriptEvent("hidekeyboard");
    --- End diff --
    
    Rather than use a static method, it'd be better to use webView.pluginManager.getPlugin("org.apache.cordova.App")
to get the instance-specific plugin instance


> Prep cordova-android for CSP by removing eval()s
> ------------------------------------------------
>
>                 Key: CB-8210
>                 URL: https://issues.apache.org/jira/browse/CB-8210
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>    Affects Versions: Master
>            Reporter: Jason Chase
>            Assignee: Andrew Grieve
>
> In preparation for CSP, remove any native code in cordova-android is that using inline
javascript/eval()s.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message