cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Clelland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8125) file transfer plugin tests often crash the mobilespec test app
Date Fri, 05 Dec 2014 15:17:12 GMT

    [ https://issues.apache.org/jira/browse/CB-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235594#comment-14235594
] 

Ian Clelland commented on CB-8125:
----------------------------------

Thanks for tackling this, [~dblotsky]! This test suite is probably the one in the worst condition
in the project (maybe tied with Contacts)

On the surface, this looks better in almost every respect than the old file. I have a couple
of concerns, though:

* Running it on my Nexus 7, I see three errors where there were none before. Specs 17, 28
and 29 all time out, and 17 additionally reports "Expected spy httpFail not to have been called"

* It looks like a lot of the test assertions have been removed, especially those relating
to progress events. Looking at spec.5 and spec.17, for instance, they only call {{verifyDownload()}}
now, which I think just checks the filename, and not anything else.

* I'm wondering how the helpers {{writeFile}} and {{deleteFile}} report errors -- besides
the different console messages, their success and failure operation looks the same. I get
several "could not find testFile" messages in the log, and I'm not sure if those should be
triggering errors or not.

* When a spec fails, I get a block in the log like:

{code}
functionality unsupported; response: 5
Error in Error callbackId File1955842735 : => marked Pending
processMessage failed: Error: => marked Pending
processMessage failed: Stack: undefined
processMessage failed: Message: F09 File1955842735 n5
{code}

(And no specs are actually marked pending, but I wouldn't expect any pending tests on Android
anyway)
That block is the sort of thing I expect when an exec() callback fails, but I'm not sure what's
failing and why here.

> file transfer plugin tests often crash the mobilespec test app
> --------------------------------------------------------------
>
>                 Key: CB-8125
>                 URL: https://issues.apache.org/jira/browse/CB-8125
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: mobile-spec, Plugin File Transfer, Plugin TestFramework
>    Affects Versions: 4.0.0
>         Environment: Windows, iOS, Android
>            Reporter: Dmitry Blotsky
>              Labels: file-transfer, newbie, plugin, test-framework
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Creating a mobilespec app with createmobilespec crashes non-deterministically when running
file transfer plugin tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message