Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 27 Nov 2014 05:04:12 +0000 (UTC)
From: "Shazron Abdullah (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12755683.1416173014000.32642.1417064652798@Atlassian.JIRA>
In-Reply-To: <JIRA.12755683.1416173014000@Atlassian.JIRA>
References: <JIRA.12755683.1416173014000@Atlassian.JIRA>
 <JIRA.12755683.1416173014335@arcas>
Subject: [jira] [Comment Edited] (CB-8024) Adding plugin does not add
 framework
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227264#comment-14227264 ] 

Shazron Abdullah edited comment on CB-8024 at 11/27/14 5:03 AM:
----------------------------------------------------------------

Thanks for all the work on this Anis, I've verified that that is indeed the problem.

Users can get into this state if they remove a framework from "Build Phases -> Link Binary with Libraries", and Xcode *does not* remove it from the project file tree itself (it's a bug if you ask me). If doing the reverse, Xcode removes both instances. I seem to remember this has caused some grief with users in some error reports when installing plugins, this might be a root cause.

My 2 cents is -- the entry in "Link Binary with Libraries" is actually the more important one, the entry in the project tree is just a convenience if you want to look at the framework headers. Xcode adds the project tree reference when you add the framework in "Link Binary with Libraries" (and vice versa). But removal, as I've mentioned - is a one way street, resulting in this orphaned reference.

I removed the offending framework from the project file tree, and the plugin installed normally. (I'll have to remove WebKit.framework from the project tree in the project templates in the wkwebview branch as well)


was (Author: shazron):
Thanks for all the work on this Anis, I've verified that that is indeed the problem.

Users can get into this state if they remove a framework from Build Phases -> Link Binary with Libraries, and Xcode *does not* remove it from the project file tree itself (it's a bug if you ask me). If doing the reverse, Xcode removes both instances. I seem to remember this has caused some grief with users in some error reports when installing plugins, this might be a root cause.

My 2 cents is -- the entry in "Link Binary with Libraries" is actually the more important one, the entry in the project tree is just a convenience if you want to look at the framework headers. Xcode adds the project tree reference when you add the framework in "Link Binary with Libraries" (and vice versa). But removal, as I've mentioned - is a one way street, resulting in this orphaned reference.

I removed the offending framework from the project file tree, and the plugin installed normally. (I'll have to remove WebKit.framework from the project tree in the project templates in the wkwebview branch as well)


> Adding plugin does not add framework
> ------------------------------------
>
>                 Key: CB-8024
>                 URL: https://issues.apache.org/jira/browse/CB-8024
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib, Plugman
>         Environment: OS X Yosemite 10.10
>            Reporter: Shazron Abdullah
>            Priority: Critical
>
> This can be repro'ed consistently:
> {code}
> cordova create wkwvtest test.project wkwvtest
> cd wkwvtest
> cordova platform add ios@wkwebview --usegit
> cordova plugin add https://github.com/apache/cordova-plugins.git#master:wkwebview-engine
> {code}
> Then, do a :
> {code}
> cordova build
> {code}
> The build fails because WebKit.framework was not added. It is specified in the plugin.xml: https://github.com/apache/cordova-plugins/blob/49b82c688a6d53c19bcd25098b4fac7f2f666680/wkwebview-engine/plugin.xml#L29
> *Expected:*
> Build is successful
> *Actual:*
> Build fails because WebKit.framework is not added.
> *Workaround:*
> Manually open the Xcode project, and add WebKit.framework. Unfortunately this is sometimes outside of the capability of some users, and this will fail on  SaaS environments like PhoneGap Build, Telerik, etc.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org