Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 24 Nov 2014 06:33:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12751380.1414591065000.4401.1416810792840@Atlassian.JIRA>
In-Reply-To: <JIRA.12751380.1414591065000@Atlassian.JIRA>
References: <JIRA.12751380.1414591065000@Atlassian.JIRA>
 <JIRA.12751380.1414591065002@arcas>
Subject: [jira] [Commented] (CB-7896) Some tests for plugin contacts are
 fails for windows because methods are not supported
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222716#comment-14222716 ] 

ASF GitHub Bot commented on CB-7896:
------------------------------------

Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/49#discussion_r20774412
  
    --- Diff: tests/tests.js ---
    @@ -24,8 +24,9 @@ exports.defineAutoTests = function () {
       // all of the setup/teardown test methods can reference the following variables to make sure to do the right cleanup
       var gContactObj = null,
         gContactId = null,
    -    isWindowsPhone = cordova.platformId == 'windowsphone';
    -
    +    isWindowsPhone8 = cordova.platformId == 'windowsphone',
    +    isWindows = (cordova.platformId === "windows") || (navigator.appVersion.indexOf("MSAppHost/1.0") !== -1),
    +    isWindowsPhone81 = (navigator.appVersion.indexOf("Windows Phone 8.1;") !== -1);
    --- End diff --
    
    isWindows = (cordova.platformId === "windows") || (cordova.platformId === "windows8")
    isWindowsPhone81 =  isWIndows && WinJS.Utilities.isPhone


> Some tests for plugin contacts are fails for windows because methods are not supported
> --------------------------------------------------------------------------------------
>
>                 Key: CB-7896
>                 URL: https://issues.apache.org/jira/browse/CB-7896
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: mobile-spec, Plugin Contacts, Windows
>            Reporter: Maria Bukharina
>
> Repo steps:
> 1. create mobile-spec app
> 2. run Plugin auto test for plugin contacts
> Expected: if method doesn't siupport pending test
> Actual: tests for "Find" and "Save" methods are failed


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org