cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7970) Add cordova-plugin-vibration support for Windows Phone 8.1
Date Tue, 25 Nov 2014 18:47:13 GMT

    [ https://issues.apache.org/jira/browse/CB-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224978#comment-14224978
] 

ASF GitHub Bot commented on CB-7970:
------------------------------------

Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64450100
  
    There are a few issues here.  Strictly saying support is added for Windows Phone 8.1 will
confuse users who probably don't know the major underlying differences between what we call
a cordova-wp8 app and a cordova-windows ( universal with target of wp8.1 )
    
    We need to be extremely clear about this so users understand.
    
    I would preface the device supports document with : windows ( univeral w/ target --phone
) or something.
    
    I would also like to let this stew a bit, so I can restructure some of the way the windows-universal
solution adds c# and c++ code.  I find it unwieldy to keep adding projects to the solution,
and would like to have a better architecture for this. I will be doing a feature branch to
prove the concept.


> Add cordova-plugin-vibration support for Windows Phone 8.1
> ----------------------------------------------------------
>
>                 Key: CB-7970
>                 URL: https://issues.apache.org/jira/browse/CB-7970
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Vibration
>            Reporter: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message