cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6472) Adding content to -Info.plist - Unexpected behaviour
Date Sat, 22 Nov 2014 02:52:34 GMT

    [ https://issues.apache.org/jira/browse/CB-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221777#comment-14221777
] 

ASF GitHub Bot commented on CB-6472:
------------------------------------

Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/115#issuecomment-64065820
  
    Cool, thanks. Merged.
    
    For the linters, looks like the authors of JSCS and jshint work together and actually
recommend using them both in combination. https://github.com/jshint/jshint/issues/1358
    We do have a jscs config file in this project, but some work is still needed before we
can start enforcing it as part of npm test.


> Adding content to -Info.plist - Unexpected behaviour
> ----------------------------------------------------
>
>                 Key: CB-6472
>                 URL: https://issues.apache.org/jira/browse/CB-6472
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: 3.4.0
>         Environment: Mac OS X
>            Reporter: Jean-Christophe Hoelt
>            Priority: Minor
>
> Trying to add content NOT at the root of info.plist, to a node already having existing
content.
> The existing content gets deleted, not merged with new content.
> Use case: a plugin providing Newsstand integration.
> Doing this in plugin.xml:
> {code}
>         <config-file target="*-Info.plist" parent="CFBundleIcons">
>             <dict>
>                 <key>CFBundlePrimaryIcon</key>
>                 <dict>
>                     <key>UINewsstandIcon</key>
>                     <dict>
>                        ...
> {code}
> Info.plist before install:
> {code}
>     <key>CFBundleIcons</key>
>     <dict>
>       <key>CFBundlePrimaryIcon</key>
>       <dict>
>         <key>CFBundleIconFiles</key>
>         <array>
>           ...
>         </array>
>       </dict>
>     </dict>
> {code}
> Info.plist after install:
> {code}
>     <key>CFBundleIcons</key>
>     <dict>
>       <key>CFBundlePrimaryIcon</key>
>       <dict>
>         <key>UINewsstandIcon</key>
>         <dict>
>           ...
>         </dict>
>       </dict>
>     </dict>
> {code}
> Info.plist expected:
> {code}
>     <key>CFBundleIcons</key>
>     <dict>
>       <key>CFBundlePrimaryIcon</key>
>       <dict>
>         <key>UINewsstandIcon</key>
>         <dict>
>           ...
>         </dict>
>         <key>CFBundleIconFiles</key>
>         <array>
>           ...
>         </array>
>       </dict>
>     </dict>
> {code}
> If this is not unexpected behaviour, then I'd make this issue a feature request: adding
an option like "merge=true".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message