cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6393) Make {File|Directory}Entry.toURL() return something useful for developers
Date Thu, 20 Nov 2014 18:04:34 GMT

    [ https://issues.apache.org/jira/browse/CB-6393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219680#comment-14219680
] 

ASF GitHub Bot commented on CB-6393:
------------------------------------

Github user clelland commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/33#issuecomment-63851664
  
    It's not included, because the master branch ended up evolving slightly differently. The
patch for [CB-6393](https://issues.apache.org/jira/browse/CB-6393) (commit 37bedcb0) fixed
this in a different, though essentially equivalent way.
    
    There is one intermediary function now, `toInternalURL`, which encapsulates the `this.filesystem.__format__(this.fullPath)`
part of this PR, but otherwise, the change represented by this PR is present in the master
branch, and has been since April of this year. (v1.0.2)


> Make {File|Directory}Entry.toURL() return something useful for developers
> -------------------------------------------------------------------------
>
>                 Key: CB-6393
>                 URL: https://issues.apache.org/jira/browse/CB-6393
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin File
>            Reporter: Ian Clelland
>            Assignee: Ian Clelland
>
> [Relevant mailing list thread|http://markmail.org/thread/iarsjqjynd7kpcyk]
> {{FileEntry.toURL()}} and {{DirectoryEntry.toURL()}} should return, by default, URLs
which are usable by the webview, as {{src}} for video, audio and image tags.
> Practically, this means that {{.toURL()}} should return the same values as {{.toNativeURL()}}
currently does: a file URL if possible; a content (Android) or assets-library (iOS) library
if that's required, or a cdvfile URL as a last resort.
> {{.toNativeURL}} should stick around for a while (with a deprecation notice) since it's
been released, and I've advocated its use on various forums. It should have exactly the same
semantics as {{.toURL}} though.
> We can introduce a {{.toInternalURL}} method to format cdvfile URLs for passing over
the bridge, since that is the format that the native side of the file plugin expects, and
it would be nice to have a single place where that conversion is done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message