Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A63D017D29 for ; Tue, 7 Oct 2014 14:25:34 +0000 (UTC) Received: (qmail 51019 invoked by uid 500); 7 Oct 2014 14:25:34 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 51000 invoked by uid 500); 7 Oct 2014 14:25:33 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 50983 invoked by uid 99); 7 Oct 2014 14:25:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 14:25:33 +0000 Date: Tue, 7 Oct 2014 14:25:33 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-6994) Windows 8 does not save big file transferred using Blob MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161928#comment-14161928 ] ASF GitHub Bot commented on CB-6994: ------------------------------------ Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-58192316 Just an additional proposed improvement to improve readability (not critical): it will be great if blob/array buffer writing logic is wrapped to separate functions (writeArrayBufferAsync/writeBlobAsync), similar to Windows.Storage.FileIO.writeBytesAsync Windows.Storage.FileIO.writeTextAsync So we can continue using logic with writePromise: if (data instanceof ArrayBuffer) { writePromise = writeArrayBufferAsync; } else if (data instanceof Blob) { writePromise = writeBlobAsync; } else if ... > Windows 8 does not save big file transferred using Blob > ------------------------------------------------------- > > Key: CB-6994 > URL: https://issues.apache.org/jira/browse/CB-6994 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File, Windows 8 > Affects Versions: 3.5.0 > Reporter: Maxime LUCE > Assignee: Maxime LUCE > Fix For: 3.6.0 > > > When trying to save Blob using FileWriter.write method, if the blob's size is too high, we get a stack overflow exception during the conversion of the blob into an basic array. > WinRT (WinJS) provide a method to write Blob directly to the filesystem. It uses Streams so it's safe for memory. > More info at : > http://code.msdn.microsoft.com/windowsapps/Blob-Sample-0e35889e/sourcecode?fileId=43594&pathId=962515806 > Method : writeBlobToFile -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org