Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 5 Oct 2014 03:22:33 +0000 (UTC)
From: "Kevin Hawkins (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12633467.1361478280000.192453.1412479353962@Atlassian.JIRA>
In-Reply-To: <JIRA.12633467.1361478280000@Atlassian.JIRA>
References: <JIRA.12633467.1361478280000@Atlassian.JIRA>
 <JIRA.12633467.1361478280457@arcas>
Subject: [jira] [Commented] (CB-2520) iOS: "original" user agent needs to be
 overridable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159410#comment-14159410 ] 

Kevin Hawkins commented on CB-2520:
-----------------------------------

Pull request for proposed fix: https://github.com/apache/cordova-ios/pull/112

> iOS: "original" user agent needs to be overridable
> --------------------------------------------------
>
>                 Key: CB-2520
>                 URL: https://issues.apache.org/jira/browse/CB-2520
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Kevin Hawkins
>              Labels: core
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> Cordova's user agent management for iOS employs a scheme of setting a baseline "original" user agent, which by default conforms to the standard user agent a UIWebView would expose, and then optionally appending CDVViewController-specific data to it in the appropriate use cases, to manage whitelisting.
> Cordova shouldn't really care too much about the data that the original user agent exposes.  I.e. it should be able to be overridden by a consumer, so that the consumer can supply its own user agent data.  This is not technically possible with the current implementation of the CDVUserAgentUtil class, since it does not exist as a member of any instance class; it's truly static/global, so inheritance doesn't come into play.
> Even if an instance of CDVuserAgentUtil could be made a property of CDVViewController, or something else, it would be kind of weird for a consumer to inherit from what's essentially a static class, just to configure their own user agent data.
> There should be another mechanism for users to override the original user agent configuration.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org