cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7820) cordova platfrom restore stops if a platforms fails to restore
Date Tue, 21 Oct 2014 00:56:33 GMT

    [ https://issues.apache.org/jira/browse/CB-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177747#comment-14177747
] 

ASF GitHub Bot commented on CB-7820:
------------------------------------

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/106#discussion_r19124580
  
    --- Diff: cordova-lib/src/cordova/restore.js ---
    @@ -54,7 +54,22 @@ function installPlatformsFromConfigXML(cfg){
         if(!targets || !targets.length  ){
             return Q.all('No platforms are listed in config.xml to restore');
         }
    -    return platform('add', targets);
    +    
    +    // Run platform add for all the platforms seperately 
    --- End diff --
    
    There's a trailing whitespace here.
    
    You're using tabs below.
    There's trailing whitespace on the blank line above here too.


> cordova platfrom restore stops if a platforms fails to restore
> --------------------------------------------------------------
>
>                 Key: CB-7820
>                 URL: https://issues.apache.org/jira/browse/CB-7820
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Gorkem ERCAN
>            Assignee: Gorkem ERCAN
>
> cordova restore platforms stops restoring platforms if one of the platforms fails to
restore. 
> For a config.xml that has android and windows when run on MacOS cordova restore will
fail on windows and never execute android restore (depending on their order) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message