cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7715) Fix windows build if folder has '.(js|htm|etc)' in name
Date Mon, 06 Oct 2014 09:10:34 GMT

    [ https://issues.apache.org/jira/browse/CB-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160123#comment-14160123
] 

ASF GitHub Bot commented on CB-7715:
------------------------------------

GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-lib/pull/99

    CB-7715 Fix windows build if folder has '.(js|htm|etc)' in name

    https://issues.apache.org/jira/browse/CB-7715
    
    * Updated regexp to match file name end and ignore case
    * Additional check to make sure we are processing file

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-7715

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
    
----
commit 0ef9330c8603ad9b028b481887d2a95ece55f497
Author: sgrebnov <v-segreb@microsoft.com>
Date:   2014-10-06T09:05:39Z

    CB-7715 Fix windows build if folder has '.(js|htm|etc)' in name

----


> Fix windows build if folder has '.(js|htm|etc)' in name
> -------------------------------------------------------
>
>                 Key: CB-7715
>                 URL: https://issues.apache.org/jira/browse/CB-7715
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib, Windows
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: bom, cordova-lib, prepare, windows
>
> Repro steps
> 1. Add folder with 'jquery.jsignature' name and corresponding content to www
> 2. cordova build
> 3. Observe the following error
> {code}
> Error: EISDIR, illegal operation on a directory
>     at Object.fs.readSync (fs.js:481:19)
>     at Object.fs.readFileSync (fs.js:320:28)
>     at c:\partitions\d\projects\html5\git\cordova\cordova-lib\cordova-lib\src\cordova\metadata\windows_parser.js:278:30
>     at Array.forEach (native)
>     at Object.module.exports.add_bom (c:\partitions\d\projects\html5\git\cordova\cordova-lib\cordova-lib\src\cordova\metadata\windows_parser.js:272:15)
>     at c:\partitions\d\projects\html5\git\cordova\cordova-lib\cordova-lib\src\cordova\metadata\windows_parser.js:251:18
>     at _fulfilled (c:\partitions\d\projects\html5\git\cordova\cordova-lib\cordova-lib\node_modules\q\q.js:798:54)
>     at self.promiseDispatch.done (c:\partitions\d\projects\html5\git\cordova\cordova-lib\cordova-lib\node_modules\q\q.js:827:30)
>     at Promise.promise.promiseDispatch (c:\partitions\d\projects\html5\git\cordova\cordova-lib\cordova-lib\node_modules\q\q.js:760:13)
>     at c:\partitions\d\projects\html5\git\cordova\cordova-lib\cordova-lib\node_modules\q\q.js:526:49
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message