cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7615) Config.xml changes cannot be made inside pre-prepare hook
Date Mon, 22 Sep 2014 20:04:33 GMT

    [ https://issues.apache.org/jira/browse/CB-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143708#comment-14143708
] 

ASF subversion and git services commented on CB-7615:
-----------------------------------------------------

Commit 2c3817e907c4ab33fca49ec2c2fd28a432980ee5 in cordova-lib's branch refs/heads/master
from [~mmocny]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=2c3817e ]

Fix CB-7615 Read config.xml after pre-prepare hooks fire


> Config.xml changes cannot be made inside pre-prepare hook
> ---------------------------------------------------------
>
>                 Key: CB-7615
>                 URL: https://issues.apache.org/jira/browse/CB-7615
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 3.6.0
>            Reporter: Michal Mocny
>            Assignee: Michal Mocny
>            Priority: Minor
>
> If your pre-prepare hook modifies the top-level application config.xml, those changes
will not be reflected until the next prepare.
> The reason is that cordova-lib incorrectly reads the state of the config file right at
the state of prepare, before running pre-prepare hooks.  Since the content isn't actually
used until after the pre-prepare hooks are fired, the fix is trivial, just read the file later
hooks fire!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message