cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
Date Tue, 09 Sep 2014 15:49:32 GMT


ASF GitHub Bot commented on CB-7499:

Github user mbillau commented on the pull request:
    @infil00p Do you think there will be any issues adding this new attribute to AndroidManifest.xml?

> Cordova dialogs should support BIDI text
> ----------------------------------------
>                 Key: CB-7499
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Dialogs
>    Affects Versions: Master
>            Reporter: Mike Billau
>            Assignee: Mike Billau
>            Priority: Minor
>              Labels: bidirectional, globalization
> Since API 19, Andorid has had the facilities to deal with bidirectional text, however,
current Cordova notification implementation does not correctly handle bidirectional text in
> We can see this is the case by first setting the language to Hebrew and then launching
the following dialogs:
>     navigator.notification.confirm("Pure English !!!", function(){}, "7"); 
>     navigator.notification.confirm("עברית היא שפה מדוברת בIsrael !",
function(){}, "8");
> Since we are in Hebrew, the base text direction will be RTL. This means that when we
see the second notification with the Hebrew text, it will be right-justified. When we click
and see the "Pure English !!!" notication, because locale is RTL, we should expect to see:
"!!! Pure English" and it should be right-justified, however, we still see "Pure English !!!",
left justified.
> Ideally you should be able to just add   android:supportsRtl="true" to the manifest,
however, this is doesn't seem to ne enough without setting the text direction to the locale
for all of the dialogs.

This message was sent by Atlassian JIRA

View raw message