cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text
Date Tue, 09 Sep 2014 15:42:28 GMT

    [ https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127122#comment-14127122
] 

ASF GitHub Bot commented on CB-7499:
------------------------------------

GitHub user mbillau opened a pull request:

    https://github.com/apache/cordova-android/pull/120

    Second part of CB-7499, support RTL text direction

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbillau/cordova-android CB-7499

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #120
    
----
commit 88fa4eec948d769b3d0924a40f6e6832fdde29a9
Author: mbillau <mike.billau@gmail.com>
Date:   2014-09-09T13:38:15Z

    Second part of CB-7499, support RTL text direction

----


> Cordova dialogs should support BIDI text
> ----------------------------------------
>
>                 Key: CB-7499
>                 URL: https://issues.apache.org/jira/browse/CB-7499
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Dialogs
>    Affects Versions: Master
>            Reporter: Mike Billau
>            Assignee: Mike Billau
>            Priority: Minor
>              Labels: bidirectional, globalization
>
> Since API 19, Andorid has had the facilities to deal with bidirectional text, however,
current Cordova notification implementation does not correctly handle bidirectional text in
dialogs.
> We can see this is the case by first setting the language to Hebrew and then launching
the following dialogs:
>     navigator.notification.confirm("Pure English !!!", function(){}, "7"); 
>     navigator.notification.confirm("עברית היא שפה מדוברת בIsrael !",
function(){}, "8");
> Since we are in Hebrew, the base text direction will be RTL. This means that when we
see the second notification with the Hebrew text, it will be right-justified. When we click
and see the "Pure English !!!" notication, because locale is RTL, we should expect to see:
"!!! Pure English" and it should be right-justified, however, we still see "Pure English !!!",
left justified.
> http://w3-03.ibm.com/globalization/page/publish/4353
> Ideally you should be able to just add   android:supportsRtl="true" to the manifest,
however, this is doesn't seem to ne enough without setting the text direction to the locale
for all of the dialogs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message