Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Date: Thu, 28 Aug 2014 21:59:10 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12736659.1409008204035.4209.1409263150495@arcas>
In-Reply-To: <JIRA.12736659.1409008204035@arcas>
References: <JIRA.12736659.1409008204035@arcas>
Subject: [jira] [Commented] (CB-7375) Investigate breaking changes at file
 plugin
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114442#comment-14114442 ] 

ASF GitHub Bot commented on CB-7375:
------------------------------------

GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/76

    [CB-7375][Entry] set proper filesystem in Entry, when moveTo or copyTo

    When the native side it doesn't return any kind of value related directly related with the fileSystem, it has to be recreated after a copy, however, it makes perfect sense, that when the entry for the copied or moved file if there's no value in entry.fileSystem, it takes the filesystem property from the parent directory that it has been moved to or copied to. So instead of return a null object or take the previous filesystem(origin) from wherever location it was copied or moved from. It would be better take the parent filesystem name and recreate it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-plugin-file CB-7375

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit 84ea94a94e68c2f4ef5c28ec91338b5932f44610
Author: Martin Gonzalez <martin.c.glez.glez@gmail.com>
Date:   2014-08-28T21:53:10Z

    [CB-7375][Entry] get proper filesystem in Entry
    
    When the native side it doesn't return any kind of value related
    directly with the fileSystem, it has to be recreated after a copy,
    however, it makes perfect sense that, when the entry for the copied or
    moved file if there's no value in entry.fileSystem, it takes the
    filesystem property from the parent directory that it has been moved to
    or copied to. So instead of return a null object or take the previous
    filesystem(origin) from whatever location it was copied from. It would
    be better take the parent filesystem name and recreate it.

----


> Investigate breaking changes at file plugin
> -------------------------------------------
>
>                 Key: CB-7375
>                 URL: https://issues.apache.org/jira/browse/CB-7375
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>    Affects Versions: 3.5.0
>            Reporter: Martin Gonzalez
>              Labels: file
>             Fix For: 3.6.0
>
>         Attachments: Jasmine-Report-File&MediaPlugin-tests_149-30-1.txt
>
>
> Some of the changes made lately to file plugin with this commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
> Are breaking changes to this plugin, affecting other platforms as android.
> Running mobile spec after that specific commit, 4 file tests are failing (test 125 -128).


--
This message was sent by Atlassian JIRA
(v6.2#6252)