cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (CB-7418) [plugin-file] Add fullPath var to condition, avoiding 'undefined/' when fullPath=null
Date Wed, 27 Aug 2014 22:46:58 GMT


ASF subversion and git services commented on CB-7418:

Commit ab42f3e7c6c2282ac303e32260e8d68fdd2e18e3 in cordova-plugin-file's branch refs/heads/master
from [~martin.c.glez.glez]
[;h=ab42f3e ]

[CB-7418][DirectoryEntry] Added fullPath variable as part of condition

As well as NativeURL property, the fullPath variable should be part of
the condition to avoid that a null value becomes a path, by adding a
slash at the end of the undefined string.
So in order to add a slash to it, fullPath should contain a value.

> [plugin-file] Add fullPath var to condition, avoiding 'undefined/' when fullPath=null
> -------------------------------------------------------------------------------------
>                 Key: CB-7418
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>    Affects Versions: 3.5.0
>            Reporter: Martin Gonzalez
>            Assignee: Martin Gonzalez
>              Labels: plugin-file
>             Fix For: 3.6.0
> DirectoryEntry.js adds a trailing slash if it's missing, however, whether is null or
not, it just checks that fullPath (!/\/$/), so in case of undefined it would convert an undefined
object into a path as 'undefined/'.

This message was sent by Atlassian JIRA

View raw message