cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7355) [CLI] removing unit tests which depend on external libraries
Date Thu, 21 Aug 2014 23:48:12 GMT

    [ https://issues.apache.org/jira/browse/CB-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106178#comment-14106178
] 

ASF subversion and git services commented on CB-7355:
-----------------------------------------------------

Commit bb2337af774f9e9aa3fe30e6baeeeea5d7adfc80 in cordova-cli's branch refs/heads/master
from [~lorin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=bb2337a ]

[CB-7355] re added single test to test call through to cordova-lib cordova raw create


> [CLI] removing unit tests which depend on external libraries
> ------------------------------------------------------------
>
>                 Key: CB-7355
>                 URL: https://issues.apache.org/jira/browse/CB-7355
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Lorin Beer
>            Assignee: Lorin Beer
>
> The cordova-cli has vestigial unit tests which now trigger on external dependencies (example
below)
> These should be removed from the cli, and migrated to the appropriate lib if necessary.
> {code}
> -        it("will NOT allow copy-from starting with 'http'", function () {
> -            var threwAnException = false;
> -            try {
> -                cli(["node", "cordova", "create", "a", "b" , "c", "--copy-from", "http://www.somesite.com"]);
> -            }
> -            catch(e) {
> -                threwAnException = true;
> -            }
> -            expect(cordova_lib.CordovaError).toHaveBeenCalledWith('Only local paths
for custom www assets are supported.');
> -            expect(threwAnException).toBe(true);
> -        });
> -
> -        it("will allow link-to with ':' char", function () {
> {code}
> in the example above, the behaviour is not implemented within the cordova cli



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message