cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7336) cordova platform add blackberry10 is broken
Date Tue, 19 Aug 2014 22:11:18 GMT

    [ https://issues.apache.org/jira/browse/CB-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102936#comment-14102936
] 

ASF GitHub Bot commented on CB-7336:
------------------------------------

Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/75#issuecomment-52706725
  
    Running npm install inside the platforms might result in some unexpected things. For example
in iOS, the node modules dir is bundles under bin/ rather as a sibling of package.json (no
idea why, and how/if they will interact).
    
    Should we just bundle node_modules with the blackberry npm package?
    
    Bundling node_modules with an npm package is not an uncommon practice. Also check npm's
bundledDependencies prop for package.json.
    
    While we are here: is there a good reason for keeping the blackberry10 name rather than
blackberry? We could leave blackberry10 as an alias translated to blackberry by the cli on
an early stage (like win variants are now) for backwards compatibility. Less complexity to
deal with later.


> cordova platform add blackberry10 is broken
> -------------------------------------------
>
>                 Key: CB-7336
>                 URL: https://issues.apache.org/jira/browse/CB-7336
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry, CLI
>    Affects Versions: 3.6.0
>            Reporter: Josh Soref
>            Priority: Blocker
>
> {quote}
> $ ~/Cordova/cordova-cli/bin/cordova platform add blackberry10
> npm http GET https://registry.npmjs.org/cordova-blackberry10/3.5.0
> npm http 404 https://registry.npmjs.org/cordova-blackberry10/3.5.0
> Unable to fetch platform blackberry10: Error: 404 Not Found: cordova-blackberry10
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message