cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7332) Module cordova/plugin/<platform>/app does not exist when packaging plugins using browserify on Windows
Date Tue, 19 Aug 2014 00:23:19 GMT

    [ https://issues.apache.org/jira/browse/CB-7332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101600#comment-14101600
] 

ASF GitHub Bot commented on CB-7332:
------------------------------------

Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-js/pull/77#discussion_r16390788
  
    --- Diff: tasks/lib/require-tr.js ---
    @@ -86,7 +88,15 @@ function _updateRequires(code) {
         if(node instanceof UglifyJS.AST_Call) {
           // check if function call is a require('module') call
           if(node.expression.name === "require" && node.args.length === 1) {
    +
    +        // Uglify is not able to recognize Windows style paths using '\' instead of '/'
    +        // So replacing all of the '/' back to Windows '\'
    +        if (node.args[0].value != undefined && node.args[0].value.indexOf('c:')
!= -1) {
    --- End diff --
    
    this will only work on the c: drive, have you considered testing ```process.platform ===
'win32'```


> Module cordova/plugin/<platform>/app does not exist when packaging plugins using
browserify on Windows
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CB-7332
>                 URL: https://issues.apache.org/jira/browse/CB-7332
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Suraj Pindoria
>            Assignee: Suraj Pindoria
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message