cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lorin Beer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-7259) Camera Plugin defaults correctOrientation to false, more intuitive if default = true.
Date Thu, 14 Aug 2014 21:54:19 GMT

    [ https://issues.apache.org/jira/browse/CB-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097389#comment-14097389
] 

Lorin Beer edited comment on CB-7259 at 8/14/14 9:53 PM:
---------------------------------------------------------

[~stevegill]
-the changes shouldn't affect any other platforms, it's a one line fix in native ios-

+sorry Steve, pull request targets common js not native ios+

Kia has now sent the iCLA in to secretary@apache twice, and I am inclined to not let apache
waste time in accepting a simple one line fix.

[~kiafathi] I would recommend you modify the commit message in the pull request. Include the
JIRA ticket number CB-7259 in the commit message.


was (Author: lorin.beer):
[~stevegill]
~~the changes shouldn't affect any other platforms, it's a one line fix in native ios~~

sorry Steve, pull request targets common js not native ios

Kia has now sent the iCLA in to secretary@apache twice, and I am inclined to not let apache
waste time in accepting a simple one line fix.

[~kiafathi] I would recommend you modify the commit message in the pull request. Include the
JIRA ticket number CB-7259 in the commit message.

> Camera Plugin defaults correctOrientation to false, more intuitive if default = true.
> -------------------------------------------------------------------------------------
>
>                 Key: CB-7259
>                 URL: https://issues.apache.org/jira/browse/CB-7259
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>    Affects Versions: 3.5.0
>         Environment: This was observed on iOS. Specifically when selecting images from
PHOTOLIBRARY
>            Reporter: Kia Thomas Fathi
>            Assignee: Steve Gill
>            Priority: Minor
>              Labels: easyfix
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Platform: iOS
> Plugin: org.apache.cordova.camera
> Hardware: iphone 5
> Strange behavior when selecting photos from library with camera.getPicture and cameraOptions
with sourceType of Camera.PictureSourceType.PHOTOLIBRARY. 
> Some photos rotate in unintuitive ways. I found that hardcoding correctOrientation to
true in my cameraOptions argument fixed this problem.
>  
> This should be set to the default option, to save time for future developers who might
encounter this behavior.
> It is a pretty easy fix, specifically:
> On line 58 of https://github.com/apache/cordova-plugin-camera/blob/master/www/Camera.js
> Current:
>   var correctOrientation = !!options.correctOrientation;
> After-Fix:
> 	var correctOrientation = options.correctOrientation === undefined ? true : !!options.correctOrientation;
> Pull Request: https://github.com/apache/cordova-plugin-camera/pull/41



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message