Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BB59911F89 for ; Tue, 22 Jul 2014 02:16:39 +0000 (UTC) Received: (qmail 25563 invoked by uid 500); 22 Jul 2014 02:16:39 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 25541 invoked by uid 500); 22 Jul 2014 02:16:39 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 25526 invoked by uid 99); 22 Jul 2014 02:16:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jul 2014 02:16:39 +0000 Date: Tue, 22 Jul 2014 02:16:39 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-7187) CordovaLib Links in CoreLocation unnecessarily MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069702#comment-14069702 ] ASF subversion and git services commented on CB-7187: ----------------------------------------------------- Commit 996259ca6c03f5dd1ff0984976532f907e337689 in cordova-plugin-device-orientation's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-orientation.git;h=996259c ] CB-7187 Delete unused #import of CDVShared.h > CordovaLib Links in CoreLocation unnecessarily > ----------------------------------------------- > > Key: CB-7187 > URL: https://issues.apache.org/jira/browse/CB-7187 > Project: Apache Cordova > Issue Type: Bug > Components: iOS > Reporter: Andrew Grieve > Assignee: Andrew Grieve > Priority: Minor > > There's some dead code in CDVShared that requires it. > Plan is to delete the dead code, and leave in an empty CDVShared.h, since it is #import'ed by: > * cordova-plugin-geolocation > * cordova-plugin-device-orientation > Will delete the references from the plugins, but we should leave in the header for a while so builds don't break. -- This message was sent by Atlassian JIRA (v6.2#6252)