Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2415411C1A for ; Fri, 18 Jul 2014 18:52:05 +0000 (UTC) Received: (qmail 13979 invoked by uid 500); 18 Jul 2014 18:52:04 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 13955 invoked by uid 500); 18 Jul 2014 18:52:04 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 13940 invoked by uid 99); 18 Jul 2014 18:52:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jul 2014 18:52:04 +0000 Date: Fri, 18 Jul 2014 18:52:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-7148) Port contacts to plugin-test-framework MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066726#comment-14066726 ] ASF GitHub Bot commented on CB-7148: ------------------------------------ GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/33 CB-7148 Ported contacts tests to plugin-test-framework Removed js-module from plugin.xml and added manual tests. Can someone please merge this into cdvtest and then merge cdvtest into master? You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-contacts CB-7148 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 ---- commit 0599cb639a28bd66d47e0025e1a9e549518f9ebe Author: Staci Cooper Date: 2014-07-18T18:44:35Z Removed js-module for tests from plugin.xml commit 5a6d05314a45964e22e86b2d8872a0d8c062a216 Author: Staci Cooper Date: 2014-07-18T18:48:52Z CB-7148 Added manual tests ---- > Port contacts to plugin-test-framework > -------------------------------------- > > Key: CB-7148 > URL: https://issues.apache.org/jira/browse/CB-7148 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Contacts, Plugin TestFramework > Reporter: Staci Cooper > Assignee: Staci Cooper > Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)