cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7187) CordovaLib Links in CoreLocation unnecessarily
Date Tue, 22 Jul 2014 02:16:39 GMT

    [ https://issues.apache.org/jira/browse/CB-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069702#comment-14069702
] 

ASF subversion and git services commented on CB-7187:
-----------------------------------------------------

Commit 996259ca6c03f5dd1ff0984976532f907e337689 in cordova-plugin-device-orientation's branch
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-orientation.git;h=996259c
]

CB-7187 Delete unused #import of CDVShared.h


> CordovaLib Links in CoreLocation unnecessarily 
> -----------------------------------------------
>
>                 Key: CB-7187
>                 URL: https://issues.apache.org/jira/browse/CB-7187
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> There's some dead code in CDVShared that requires it. 
> Plan is to delete the dead code, and leave in an empty CDVShared.h, since it is #import'ed
by:
> * cordova-plugin-geolocation
> * cordova-plugin-device-orientation
> Will delete the references from the plugins, but we should leave in the header for a
while so builds don't break.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message