cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7186) --no-signing will be ignored if --buildId is set
Date Thu, 24 Jul 2014 15:45:38 GMT

    [ https://issues.apache.org/jira/browse/CB-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073305#comment-14073305
] 

ASF GitHub Bot commented on CB-7186:
------------------------------------

Github user dylin commented on the pull request:

    https://github.com/apache/cordova-blackberry/pull/169#issuecomment-50036071
  
    we transform ww 2.0 style arguments to ww 1.0 style and pass them to packager, there are
no a corresponding things for --no-singing in packager side.  the cli front end decide signing
or not by --no-signing flag, however the back end (package_validator) check it by -g &&
-buildId, that's why it will omit --no-signing when --buildId was specified.  cmdline.js parses
the transformed args, and signing flag here will be used in package-validator.js, and won't
be passed to packager (because packager doesn't has `signing` option).


> --no-signing will be ignored if --buildId is set
> ------------------------------------------------
>
>                 Key: CB-7186
>                 URL: https://issues.apache.org/jira/browse/CB-7186
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry
>    Affects Versions: 3.5.0
>            Reporter: Danyi Lin
>            Priority: Minor
>             Fix For: 3.6.0
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> running command: build --release --buildId 123 --no-signing
> --no-signing will be ignored
> expect:
>  the bar file will be built without signing
> actual:
> the bar file was built with signing



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message