cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <>
Subject [jira] [Commented] (CB-7156) Make the pluggable webview API as good as possible
Date Wed, 16 Jul 2014 19:12:04 GMT


Andrew Grieve commented on CB-7156:

Some already-made changes:
* Move handling of Fullscreen preference to CordovaActivity from AndroidWebView
* Moved copy & pasted ExposedJsApi into shared CordovaBridge class
* Delete Cordova*Client classes since they are webview-specific
  * Moved CordovaChromeClient.getValueCallback() -> CordovaWebView.onFilePickerResult()
* Delete View-specific methods from CordovaInterface (callers should use .getView() to get
at the view)
* Reduces the number of loadUrl() overloads
* Delete addJavascript() (but leaves sendJavascript)
* Delete getPlugin() and postMessage() convenience methods (call them on PluginManager directly)
* Delete isPaused() - Used only by tests and is just a stored boolean of onPause onResume
* Delete getUrl(), but then added back in

Other APIs that might be unnecessary:
* void showWebPage(String errorUrl, boolean b, boolean c, HashMap<String, Object> params);
* boolean isCustomViewShowing();
* void showCustomView(View view, CustomViewCallback callback);
* void hideCustomView();
* void setNetworkAvailable(boolean online); (this one makes sense for the online bridge, but
doesn't really make sense to expose to plugins)
There is also a good amount of copy & pasted code  between AndroidWebView and Crosswalk
* Splashscreen code
* page load timeout

> Make the pluggable webview API as good as possible
> --------------------------------------------------
>                 Key: CB-7156
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Andrew Grieve
> Some specific goals here:
> - Eliminate CordovaWebView APIs that are engine-specific (e.g. WebViewClient)
> - Eliminate CordovaWebView APIs that are convenience methods (no need for every implementation
to implement the same convenience methods)
> - Eliminate copy & pasted code between pluggable webviews
> This issue should be left open until 4.0.x stabilizes.

This message was sent by Atlassian JIRA

View raw message