cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-7155) Reduce the visibility of symbols in Android 4.0.x
Date Wed, 16 Jul 2014 18:34:04 GMT

     [ https://issues.apache.org/jira/browse/CB-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Grieve updated CB-7155:
------------------------------

    Description: 
With a major version bump, it makes sense to use this opportunity to make some public methods/fields
non-public that should never have been public in the first place.

https://github.com/apache/cordova-android/commit/a99c8219bd90f913df9083652972c5037a8426d9
* PluginManager.clearPluginObjects(),
* PluginManager.startupPlugins()

https://github.com/apache/cordova-android/commit/6f301576ebbf2a631c7f36af3cc97d482a2d0d3d
* Makes PluginEntry fields final

https://github.com/apache/cordova-android/commit/145b50a320edfa8b5397849fc20a6295f8823ff6
* PluginEntry.createPlugin() moved into PluginManager

https://github.com/apache/cordova-android/commit/eca05e6bad881fcd2ba928f76a28e0bb96d0e4b2
* Convenience methods in CordovaActivity
* Removing convenience methods might break the compile for those that have made customizations
to their Activity.java class, but the changes are trivial to fix for those capable of editing
their own Activity.java file.

Although some commits have been made already to this goal, going to leave issue open until
4.0.x stabilizes. 


  was:
With a major version bump, it makes sense to use this opportunity to make some public methods/fields
non-public that should never have been public in the first place.

https://github.com/apache/cordova-android/commit/a99c8219bd90f913df9083652972c5037a8426d9
* PluginManager.clearPluginObjects(),
* PluginManager.startupPlugins()

https://github.com/apache/cordova-android/commit/6f301576ebbf2a631c7f36af3cc97d482a2d0d3d
* Makes PluginEntry fields final

https://github.com/apache/cordova-android/commit/145b50a320edfa8b5397849fc20a6295f8823ff6
* PluginEntry.createPlugin() moved into PluginManager

https://github.com/apache/cordova-android/commit/eca05e6bad881fcd2ba928f76a28e0bb96d0e4b2
* Convenience methods in CordovaActivity

Although some commits have been made already to this goal, going to leave issue open until
4.0.x stabilizes. 



> Reduce the visibility of symbols in Android 4.0.x
> -------------------------------------------------
>
>                 Key: CB-7155
>                 URL: https://issues.apache.org/jira/browse/CB-7155
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> With a major version bump, it makes sense to use this opportunity to make some public
methods/fields non-public that should never have been public in the first place.
> https://github.com/apache/cordova-android/commit/a99c8219bd90f913df9083652972c5037a8426d9
> * PluginManager.clearPluginObjects(),
> * PluginManager.startupPlugins()
> https://github.com/apache/cordova-android/commit/6f301576ebbf2a631c7f36af3cc97d482a2d0d3d
> * Makes PluginEntry fields final
> https://github.com/apache/cordova-android/commit/145b50a320edfa8b5397849fc20a6295f8823ff6
> * PluginEntry.createPlugin() moved into PluginManager
> https://github.com/apache/cordova-android/commit/eca05e6bad881fcd2ba928f76a28e0bb96d0e4b2
> * Convenience methods in CordovaActivity
> * Removing convenience methods might break the compile for those that have made customizations
to their Activity.java class, but the changes are trivial to fix for those capable of editing
their own Activity.java file.
> Although some commits have been made already to this goal, going to leave issue open
until 4.0.x stabilizes. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message