cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikolai Kotchetkov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7142) Support for restoring plugin "preferences" in "restore" CLI command
Date Tue, 22 Jul 2014 18:06:42 GMT

    [ https://issues.apache.org/jira/browse/CB-7142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070609#comment-14070609
] 

Nikolai Kotchetkov commented on CB-7142:
----------------------------------------

Got that Andrew!

Yes, things are getting more complicated at least with the {{prepare}} code. Can't figure
out right now what is to be done with the preference merging in a first place and how to maintain
them in features exactly :)

So will it be {{variable}} then?
If the {{preference}} strategy is described somewhere - I can try to implement it also  -
the deprecation process is always a tricky thing :) 
But for now I have no general vision on it - so it'll take more time while the outcome is
not clear...

A bit offtopic. What's wrong with having a feature in platform config? It might come in handy
as soon as the {{variable}} becomes accessible to native code. On the other side it might
be a bad practice - using config.xml instead of correctly utilizing plugin.xml to patch all
needed resources...


> Support for restoring plugin "preferences" in "restore" CLI command
> -------------------------------------------------------------------
>
>                 Key: CB-7142
>                 URL: https://issues.apache.org/jira/browse/CB-7142
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI, Plugman
>    Affects Versions: 3.5.0
>            Reporter: Nikolai Kotchetkov
>              Labels: features
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Thanks for great improvement having the plugin list in config.xml!
> However it will be great if "preferences" passed to plugman as variables could be saved
there to.
> Like:
> {noformat}
> <feature name="Custom URL scheme">
>         <param name="id" value="nl.x-services.plugins.launchmyapp" />
>         <param name="url" value="https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin.git"
/>
>         <preference name="URL_SCHEME" value="VERBOSE"/>
>     </feature>
> {noformat}
> I've made a rather simple fix for that in [this commit|https://github.com/motorro/cordova-lib/commit/4c5765404ed8714a5ea0f8d5e026d3280335405d]
> The code also has a feature of setting and using a plugin URL to install.
> Two more things required:
> # To be able to specify preferences per plugin to avoid possible name conflict - that
involves installing plugins one-by-one rather than in batch as far as I understand the 'plugin("add")'
> # Add support to reinstalling plugins with respect to preferences on platform add - did
not dig the code yet.
> It would be nice if someone comment on the issue - am I right or missing something already
done. Also I can fullfill the requirement myself and issue a pull request if the feature seems
handy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message