cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7142) Support for restoring plugin "preferences" in "restore" CLI command
Date Tue, 22 Jul 2014 13:37:39 GMT

    [ https://issues.apache.org/jira/browse/CB-7142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070258#comment-14070258
] 

Andrew Grieve commented on CB-7142:
-----------------------------------

Ah, interesting. Didn't know plugin.xml uses it. 

Still, it'll add a bit of trickiness. E.g. `ConfigParser.getPreference()` will need to change
to not consider nested preferences.

Also, the config merging done by prepare: https://github.com/motorro/cordova-lib/blob/maintain-plugin-preferencies/cordova-lib/src/cordova/prepare.js#L133

should be changed to not merge in the nested `<preference>` tags (really - it shouldn't
merge in the <feature> tags either)

Might just be simpler to not use `<preference>`. We could even look at deprecating that
term in plugin.xml and changing it to `<variable>`, since that's how we refer to this
feature in our docs.


> Support for restoring plugin "preferences" in "restore" CLI command
> -------------------------------------------------------------------
>
>                 Key: CB-7142
>                 URL: https://issues.apache.org/jira/browse/CB-7142
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI, Plugman
>    Affects Versions: 3.5.0
>            Reporter: Nikolai Kotchetkov
>              Labels: features
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Thanks for great improvement having the plugin list in config.xml!
> However it will be great if "preferences" passed to plugman as variables could be saved
there to.
> Like:
> {noformat}
> <feature name="Custom URL scheme">
>         <param name="id" value="nl.x-services.plugins.launchmyapp" />
>         <param name="url" value="https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin.git"
/>
>         <preference name="URL_SCHEME" value="VERBOSE"/>
>     </feature>
> {noformat}
> I've made a rather simple fix for that in [this commit|https://github.com/motorro/cordova-lib/commit/4c5765404ed8714a5ea0f8d5e026d3280335405d]
> The code also has a feature of setting and using a plugin URL to install.
> Two more things required:
> # To be able to specify preferences per plugin to avoid possible name conflict - that
involves installing plugins one-by-one rather than in batch as far as I understand the 'plugin("add")'
> # Add support to reinstalling plugins with respect to preferences on platform add - did
not dig the code yet.
> It would be nice if someone comment on the issue - am I right or missing something already
done. Also I can fullfill the requirement myself and issue a pull request if the feature seems
handy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message