cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7124) `cordova platform add <platform>@<version>` not working for Git based installs
Date Thu, 17 Jul 2014 21:12:05 GMT

    [ https://issues.apache.org/jira/browse/CB-7124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065555#comment-14065555
] 

ASF GitHub Bot commented on CB-7124:
------------------------------------

Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/61#issuecomment-49366276
  
    Yep, I can see you on the ICLA list here
    http://people.apache.org/committer-index.html
    Merging.


> `cordova platform add <platform>@<version>` not working for Git based installs
> ------------------------------------------------------------------------------
>
>                 Key: CB-7124
>                 URL: https://issues.apache.org/jira/browse/CB-7124
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.5.0
>            Reporter: Pascal Widdershoven
>
> Currently the {{cordova platform add <platform>@<version>}} is only working
with the {{--usenpm}} option enabled.
> I think --usenpm is disabled by default (\?) so this feature will appear broken to most
users. I've pinpointed the problem to [this peace of code|https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L86]
where for the cordova_git function the @version check is missing, resulting in a "Platform
not recognized" error when the platform includes a version code.
> I hope I can find some time to sign the ICLA and send a pull request. In general it seems
that the whole @version check could be handled more elegantly, right now it's duplicated in
several places making it easy to forget to add it somewhere.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message