cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (CB-7091) Remove check_requirements from cordova-lib
Date Tue, 08 Jul 2014 01:03:34 GMT


ASF subversion and git services commented on CB-7091:

Commit ab49973560ccb7a1ea37d9f5db4e497ef0ce92d1 in cordova-lib's branch refs/heads/master
from [~kamrik]
[;h=ab49973 ]

CB-7091: Don't call check_requirements during platform add

check_reqs is called from the platform build script, there is no use in calling it

Instead, added a simple check that if a platform has a list of compatible host
OSs (defined in platforms.js), the host OS is checked against this list.

> Remove check_requirements from cordova-lib
> ------------------------------------------
>                 Key: CB-7091
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Mark Koudritsky
>            Assignee: Mark Koudritsky
> As per this discussion [1] check_requirements() functions in platform parsers are redundant.
The same check is executed twice, once via cordova create call_into_create() -> platform_parser
> and then again from the platform create script.
> Removing 
> 1) The call to check_requriements() from create.js:call_into_create(). 
> 2) The check_requirements() functions from platform parsers in metadata.
> Adding:
> A simple check that the host OS is listed in platforms[platform].hostos
> [1]

This message was sent by Atlassian JIRA

View raw message