cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7091) Remove check_requirements from cordova-lib
Date Tue, 08 Jul 2014 15:23:04 GMT

    [ https://issues.apache.org/jira/browse/CB-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055038#comment-14055038
] 

ASF subversion and git services commented on CB-7091:
-----------------------------------------------------

Commit 153092f2c235185c7f141979a550779800954a92 in cordova-lib's branch refs/heads/master
from [~kamrik]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=153092f ]

CB-7091: Remove check_requirements() funcs from platform parsers

No longer used, removing. They were either:
1) Empty
2) Duplicating the chqck_reqs call that is also done by platform create scripts
3) In Ubuntu duplicated the code from check_reqs


> Remove check_requirements from cordova-lib
> ------------------------------------------
>
>                 Key: CB-7091
>                 URL: https://issues.apache.org/jira/browse/CB-7091
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Mark Koudritsky
>            Assignee: Mark Koudritsky
>
> As per this discussion [1] check_requirements() functions in platform parsers are redundant.
The same check is executed twice, once via cordova create call_into_create() -> platform_parser
...
> and then again from the platform create script.
> Removing 
> 1) The call to check_requriements() from create.js:call_into_create(). 
> 2) The check_requirements() functions from platform parsers in metadata.
> Adding:
> A simple check that the host OS is listed in platforms[platform].hostos
> [1] https://www.mail-archive.com/dev%40cordova.apache.org/msg19084.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message