cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7067) run jasmine tests individually
Date Thu, 03 Jul 2014 03:26:24 GMT

    [ https://issues.apache.org/jira/browse/CB-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051021#comment-14051021
] 

ASF GitHub Bot commented on CB-7067:
------------------------------------

GitHub user jsoref opened a pull request:

    https://github.com/apache/cordova-lib/pull/51

    CB-7067 run jasmine tests individually

    CB-7067 run jasmine tests individually
    
    `superspawn.spawn` `opts` now take `onstdio` and `onstderr` to
    incrementally handle output from child processes.
    
    `npm run jasmine` now runs `jasmine-serial` instead of `jasmine-node`
    
    `jasmine-serial` runs each test that `jasmine-node` would have run
    in the same order `jasmine-node` would have run them using
    `jasmine-node` with any command-line arguments you pass it (that
    `jasmine-serial` supports).
    
    `serve.spec` now skips tests for platforms for which it's missing
    the required binaries.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jsoref/cordova-lib cb_7067

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit d81e946500ed7daffe579b3904161149e5eef25e
Author: Josh Soref <jsoref@blackberry.com>
Date:   2014-07-03T01:09:39Z

    CB-7067 run jasmine tests individually
    
    `superspawn.spawn` `opts` now take `onstdio` and `onstderr` to
    incrementally handle output from child processes.
    
    `npm run jasmine` now runs `jasmine-serial` instead of `jasmine-node`
    
    `jasmine-serial` runs each test that `jasmine-node` would have run
    in the same order `jasmine-node` would have run them using
    `jasmine-node` with any command-line arguments you pass it (that
    `jasmine-serial` supports).
    
    `serve.spec` now skips tests for platforms for which it's missing
    the required binaries.

----


> run jasmine tests individually
> ------------------------------
>
>                 Key: CB-7067
>                 URL: https://issues.apache.org/jira/browse/CB-7067
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>
> The way we run tests right now has a couple of painful points:
> 1. We can't skip only some tests in a single spec file because jasmine is treating all
of our tests as a single set run together, and so by saying "I want to prefer test X in file
A", it's interpreting that as "I don't want to run any other tests in any other file unless
they are also preferred". That's pretty annoying.
> 2. Spys and other manipulations we do in a spec can have adverse impact on unrelated
tests. Trying to get tests to work thus involves debugging all other tests and hunting for
common problems.
> Neither of these things pain ports are necessary afaict.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message